codehaus


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[nova][ptg] Ussuri scope containment


On 2019-10-01 08:38:50 -0400 (-0400), Tom Barron wrote:
[...]
> In projects I have worked on there is no need to encourage extra
> begging and squeaky wheel prioritization has IMO not been a
> healthy thing.
> 
> There is no better way to get ones reviews stalled than to beg for
> reviews with patches that are not close to ready for review and at
> the same time contribute no useful reviews oneself.
> 
> There is nothing wrong with pinging to get attention to a review
> if it is ready and languishing, or if it solves an urgent issue,
> but even in these cases a ping from someone who doesn't "cry wolf"
> and who has built a reputation as a contributor carries more
> weight.
[...]

Agreed, it drives back to Eric's comment about familiarity with the
team's reviewer culture. Just saying "hey I pushed these patches can
someone look" is often far less effective for a newcomer than "I
reported a bug in subsystem X which is really aggravating and review
654321 fixes it if anyone has a moment to look" or "tbarron: I
addressed your comments on review 654321 when you get a chance to
revisit your -1, thanks!"

My cardinal rules of begging: Don't mention the nicks of random
people who have not been involved in the change unless you happen to
actually know it's one they'll personally be interested in. Provide
as much context as possible (within reason) to attract the actual
interest of potential reviewers. Be polite, thank people, and don't
assume your change is important to anyone nor that there's someone
who has time to look at it. And most important, as you noted too, if
you're waiting around then take a few minutes and go review
something to pass the time! ;)
-- 
Jeremy Stanley
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: not available
URL: <http://lists.openstack.org/pipermail/openstack-discuss/attachments/20191001/e684a945/attachment.sig>