codehaus


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] mod_deflate: hardcoded "%ld" -> APR_OFF_T_FMT


On Sun, Dec 23, 2018 at 10:33 AM Stefan Sperling <stsp@xxxxxxxxxx> wrote:
>
> On Wed, Dec 19, 2018 at 07:03:39PM +0100, Stefan Sperling wrote:
> > On Wed, Dec 19, 2018 at 02:58:28PM +0100, Yann Ylavic wrote:
> > > On Wed, Dec 19, 2018 at 9:53 AM Stefan Sperling <stsp@xxxxxxxxxx> wrote:
> > > >
> > > > On Tue, Dec 18, 2018 at 12:29:18AM +0100, Yann Ylavic wrote:
> > > > > But yes, upcast is better, while at it I'd go for uint64_t...
> > > >
> > > > Like this?
> > >
> > > I think APR_UINT64_T_FMT/apr_uint64_t would be more portable ;)
> > >
> > > Thanks for taking care of this !
> >
> > Sure :)
>
> Committed.

Thanks Stefan, I didn't notice before in your proposed patch, but it
looks like uint64_t casts should be apr_uint64_t too.

Regards,
Yann.