Re: [IO] Robust file remover, other Windows-specific enhancements
On Fri, Dec 21, 2018, 11:11 Matt Sicker <boards@xxxxxxxxx wrote:
> I like that idea. I'll reorganize some code from the Jenkins PR into a one
> for IO.
> On Fri, 21 Dec 2018 at 11:51, Gary Gregory <garydgregory@xxxxxxxxx> wrote:
> > That could go in Commons IO, sure.
> > I would prefer the code to go in a focused class like a DeleteUtils or
> > DeleteFiles. It might also be neat to make the class instantiable and
> > configurable instead of having lots of options args.
> > Gary
> > On Fri, Dec 21, 2018, 09:58 Matt Sicker <boards@xxxxxxxxx wrote:
> > > I've been refactoring some IO code in Jenkins lately that are similar
> > > the FileUtils delete family of methods. I had originally wanted to
> > replace
> > > them with calls to FileUtils, but I noticed that we had a more
> > > sophisticated strategy for retrying deletes and other workarounds for
> > > (usually) Windows-specific problems (e.g., you can't delete an open
> > in
> > > Windows; this can be commonly caused by things like virus scanners
> > > cause ephemeral errors).
> > >
> > > My Jenkins code is here , and I was wondering if I could work on
> > > contributing some of this logic back to commons-io in some way. There
> > > also be some useful utilities to include regarding Windows-specific
> > > symbolic link/directory junction manipulation, too.
> > >
> > > : https://github.com/jenkinsci/jenkins/pull/3812
> > >
> > > --
> > > Matt Sicker <boards@xxxxxxxxx>
> > >
> Matt Sicker <boards@xxxxxxxxx>