codehaus


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [VOTE][RC1] Commons collections 4.3


My bad,

Here is the analysis (please correct me if I'm wrong)
Errors:
1) `org.apache.commons.collections4.BidiMap:: Method 'public
java.util.Collection values()' has been added to an interface`
2) `org.apache.commons.collections4.ListValuedMap:: Method 'public
java.util.Collection get(java.lang.Object)' has been added to an
interface`
3) `org.apache.commons.collections4.ListValuedMap:: Method 'public
java.util.Collection remove(java.lang.Object)' has been added to an
interface`
4) `org.apache.commons.collections4.OrderedBidiMap:: Method 'public
org.apache.commons.collections4.BidiMap inverseBidiMap()' has been
added to an interface`
5) `org.apache.commons.collections4.OrderedMap:: Method 'public
org.apache.commons.collections4.MapIterator mapIterator()' has been
added to an interface`
6) `org.apache.commons.collections4.SetValuedMap:: Method 'public
java.util.Collection get(java.lang.Object)' has been added to an
interface`
7) `org.apache.commons.collections4.SetValuedMap:: Method 'public
java.util.Collection remove(java.lang.Object)' has been added to an
interface`
8) `org.apache.commons.collections4.SortedBidiMap:: Method 'public
org.apache.commons.collections4.OrderedBidiMap inverseBidiMap()' has
been added to an interface`
9) `org.apache.commons.collections4.SortedBidiMap:: Method 'public
org.apache.commons.collections4.BidiMap inverseBidiMap()' has been
added to an interface`
    these errors are weird. Above classes has no changes comparing to 4.2 [1]

Infos:
1) `org.apache.commons.collections4.SetUtils:: Method 'public
java.util.HashSet hashSet(java.lang.Object[])' has been added`
2) `org.apache.commons.collections4.SetUtils:: Method 'public
java.util.Set unmodifiableSet(java.lang.Object[])' has been added`
    both methods are public static and implemented, should cause no issues
3) - 6) `org.apache.commons.collections4.map.AbstractReferenceMap`
    methods with implementations were added to class, and
accessibility has been increased

I see no issues need to be noted

[1] https://github.com/apache/commons-collections/compare/commons-collections-4.2-RC1...collections-4.3-RC1

On Thu, 20 Dec 2018 at 00:29, sebb <sebbaz@xxxxxxxxx> wrote:
>
> On Wed, 19 Dec 2018 at 16:09, Maxim Solodovnik <solomax666@xxxxxxxxx> wrote:
> >
> > Thanks for checking Gilles,
> >
> > Regarding clirr errors instruction states [1] to check errors only for
> > minor release
>
> That is not the understanding I have of how to handle Clirr errors,
> nor does the doc [1] actually say that.
> The cited doc [1] does not detail the process for major releases.
>
> A major release can be binary incompatible, but in that case a new
> package name and Maven coords are needed so the old and new versions
> can co-exist.
>
> Errors reported by Clirr can never be ignored.
>
> > Since it is 4.3.0 and not 4.2.1 I thought it is OK ..
> > How this should be properly addressed?
>
> In all cases, errors must be examined.
> The Clirr plugin does not distinguish binary and source compatibility
> issues, so it's not always obvious what to do.
>
> In this case, additions to interfaces are binary compatible - i.e.
> don't create problems at run-time - however source changes may be
> required if a 3rd party source implements the interface.
>
> Is it possible to avoid these by using default implementations?
> Are the interfaces part of the external API?
>
> Any Clirr errors should be noted in the Release Notes, with
> information on how they affect the user.
>
> > release_4_3.html was not genarated during build :( How can I generate it?
> >
> > Is it possible to perform site re-generation and maybe manual update
> > of apache-dev?
> >
> > I will be OOO Thu-Sun, so will resolve all issues on return
> >
> > [1] https://gitbox.apache.org/repos/asf?p=commons-rng.git;a=blob;f=doc/release/release.howto.txt#l73
> >
> > On Wed, 19 Dec 2018 at 21:59, Gilles <gilles@xxxxxxxxxxxxxxxxxxxxx> wrote:
> > >
> > > Hi.
> > >
> > > Congratulations for getting that far in a fairly short time. ;-)
> > >
> > > The BC report (Clirr) notes several incompatible changes:
> > >
> > > https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC1/site/clirr-report.html
> > > [No idea whether that was expected.  If so, perhaps there should be
> > > a remark in the release notes?]
> > >
> > > In the site, the link to the release note is dead:
> > >
> > > https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC1/site/release_4_3.html
> > > [File must be copied manually (?). It does not seem to be at same place
> > > in "Collections" and in "RNG"!]
> > >
> > > On Wed, 19 Dec 2018 20:41:15 +0700, Maxim Solodovnik wrote:
> > > > This is a [VOTE] for releasing
> > > > Apache Commons collections 4.3
> > > >
> > > > Tag name:
> > > > collections-4.3-RC1 (signature can be checked from git using 'git tag
> > > > -v')
> > >
> > > OK.
> > >
> > > > Tag URL:
> > > >
> > > >
> > > > https://gitbox.apache.org/repos/asf?p=commons-collections.git;a=commit;h=5f959fd8e77bf28f6286cfb4d1e1fff27167f803
> > > >
> > > > Commit ID the tag points at:
> > > >     5f959fd8e77bf28f6286cfb4d1e1fff27167f803
> > >
> > > OK.
> > >
> > > >
> > > > Site:
> > > >
> > > >
> > > > https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC1/site/index.html
> > >
> > > Download page will be wrong (cf. other thread with subject "Fixing
> > > the download page).
> > >
> > > >
> > > > Distribution files (committed at revision 31605):
> > > >     https://dist.apache.org/repos/dist/dev/commons/collections/
> > > >
> > > > Distribution files hashes (SHA256):
> > > >     201e1d527c67643b4e75065e113006d0610e8bf5620b4e056a2e044f3676df12
> > > > commons-collections4-4.3-bin.tar.gz
> > >
> > > OK.
> > >
> > > >     706a0f5b4ddfd85e5444933576ea37776219748973bf4fc3944d846823f79395
> > > > commons-collections4-4.3-bin.zip
> > > >     7a18a39b8b24d8688400276388d5c63da448ee7a8166561a5cffb617b952ed96
> > > > commons-collections4-4.3-src.tar.gz
> > >
> > > OK.
> > >
> > > >     8a7b3ccd3fb2ba7edde7e08aa7606b3eacef260eab887358c56473a9e395067a
> > > > commons-collections4-4.3-src.zip
> > > >
> > > > KEYS file to check signatures:
> > > >     https://www.apache.org/dist/commons/KEYS
> > > >
> > > > Maven artifacts:
> > > >
> > > > https://repository.apache.org/content/repositories/orgapachecommons-1401/
> > > >
> > > > Please select one of the following options:
> > > >   [ ] +1 Release it.
> > > >   [ ] +0 Go ahead; I don't care.
> > > >   [ ] -0 There are a few minor glitches: ...
> > > >   [ ] -1 No, do not release it because ...
> > > >
> > > > This vote will be open for at least 72 hours, i.e. until
> > > > 2018-12-22T14:00:00Z
> > > > (this is UTC time).
> > > >
> > >
> > > Regards,
> > > Gilles
> > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@xxxxxxxxxxxxxxxxxx
> > > For additional commands, e-mail: dev-help@xxxxxxxxxxxxxxxxxx
> > >
> >
> >
> > --
> > WBR
> > Maxim aka solomax
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@xxxxxxxxxxxxxxxxxx
> > For additional commands, e-mail: dev-help@xxxxxxxxxxxxxxxxxx
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@xxxxxxxxxxxxxxxxxx
> For additional commands, e-mail: dev-help@xxxxxxxxxxxxxxxxxx
>


-- 
WBR
Maxim aka solomax

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@xxxxxxxxxxxxxxxxxx
For additional commands, e-mail: dev-help@xxxxxxxxxxxxxxxxxx