][Thread Next][Date Index
Re: AIP-6: Enforce the usage of a code formatter
Sounds like a good idea to me. However, applying one of the code formatters
to the complete codebase would break all existing PR's. Maybe we can enable
something like a diff: https://github.com/google/yapf/issues/190
Op zo 30 dec. 2018 om 13:42 schreef Kaxil Naik <kaxilnaik@xxxxxxxxx>:
> Not sure about code formatter but we definitely need some linting tool.
> However, code formatter can be a positive change.
> On Sun, Dec 30, 2018, 12:12 Bas Harenslak <basharenslak@xxxxxxxxxxxxxxxx
> > Wanted to point out I created an Airflow AIP for introducing a code
> > formatter:
> > .
> > I created an AIP since enforcing a code formatter will make a large
> > of changes and result in a few PR conflicts. I wonder what peoples
> > on it is.
> > Bas